Add types entry in export map
#12073
Conversation
Since the presence of an export map overrides any other entrypoint methods. Technically not required, since `./build/jest.d.ts` is adjacent to `./build/jest.js` and will be found via that adjacency, but can be included for completeness, just like the top-level `"types": "./build/jest.d.ts"` entry.
|
Hi @weswigham! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks @weswigham! As CI is pointing out, this PR needs to also
EDIT: oh, and a changelog entry would be great 🙂 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This adds a
typesentry in export map since the presence of an export map overrides any other entrypoint methods. Technically not required, since./build/jest.d.tsis adjacent to./build/jest.jsand will be found via that adjacency, but can be included for completeness, just like the top-level"types": "./build/jest.d.ts"entry.