jest-worker: Avoid crash when "--max-old-space-size" inside `process.execArgv` #12097

SuperOleg39 · 2021-11-29T16:28:05Z

jest-worker used by terser-webpack-plugin

In our cli, we run build process with max-old-space-size flag by default, and use terser-webpack-plugin inside.

So, terser-webpack-plugin initialize ExperimentalWorker, and ExperimentalWorker pass max-old-space-size to NodeJS worker, then process failed with error:

error GLOBAL:ERROR Error: platform.3c72a39d93fe42d9bfb2.js from Terser plugin
Initiated Worker with invalid execArgv flags: --max_old_space_size=3000
Error [ERR_WORKER_INVALID_EXEC_ARGV]: Initiated Worker with invalid execArgv flags: --max_old_space_size=3000
    at new NodeError (node:internal/errors:371:5)
    at new Worker (node:internal/worker:191:13)
    at ExperimentalWorker.initialize (/builds/coretech-frontend/tramvai/smokeNpm/node_modules/jest-worker/build/workers/NodeThreadsWorker.js:149:20)
    at new ExperimentalWorker (/builds/coretech-frontend/tramvai/smokeNpm/node_modules/jest-worker/build/workers/NodeThreadsWorker.js:145:10)
    at WorkerPool.createWorker (/builds/coretech-frontend/tramvai/smokeNpm/node_modules/jest-worker/build/WorkerPool.js:44:12)
    at new BaseWorkerPool (/builds/coretech-frontend/tramvai/smokeNpm/node_modules/jest-worker/build/base/BaseWorkerPool.js:127:27)
    at new WorkerPool (/builds/coretech-frontend/tramvai/smokeNpm/node_modules/jest-worker/build/WorkerPool.js:30:1)
    at new Worker (/builds/coretech-frontend/tramvai/smokeNpm/node_modules/jest-worker/build/index.js:167:26)
    at getWorker (/builds/coretech-frontend/tramvai/smokeNpm/node_modules/terser-webpack-plugin/dist/index.js:391:9)
    at /builds/coretech-frontend/tramvai/smokeNpm/node_modules/terser-webpack-plugin/dist/index.js:494:41

…xecArgv

SuperOleg39 · 2021-11-29T16:29:16Z

@kherock hi!

Fyi, change the code from you last commit, maybe you can help with review?

SuperOleg39 · 2021-11-29T16:44:01Z

Found old PR with similar problem - https://github.com/parcel-bundler/parcel/pull/5017/files

codecov-commenter · 2021-11-29T16:53:05Z

Codecov Report

Merging #12097 (9431272) into main (40a9027) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #12097      +/-   ##
==========================================
- Coverage   68.91%   68.90%   -0.01%     
==========================================
  Files         324      324              
  Lines       16681    16682       +1     
  Branches     4814     4814              
==========================================
  Hits        11495    11495              
- Misses       5153     5154       +1     
  Partials       33       33

Impacted Files	Coverage Δ
...kages/jest-worker/src/workers/NodeThreadsWorker.ts	`93.61% <100.00%> (+0.06%)`	⬆️
packages/expect/src/utils.ts	`96.03% <0.00%> (-0.50%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40a9027...9431272. Read the comment docs.

kherock

This seems fine to me. I'd suggest adding a unit test assertion for this, there's a similar one you can borrow testing --inspect in the child process worker test file.

poman31 · 2021-11-29T19:03:38Z

I am also seeing this error as of 27.4.0 version of jest-worker and angular 12 cli. Had to downgrade to jest-worker 27.3.1 to fix the compilation failure

styles.b2ce177b96dbbf74326c.css - Error: styles.b2ce177b96dbbf74326c.css from Css Minimizer Error [ERR_WORKER_INVALID_EXEC_ARGV]: Initiated Worker with invalid execArgv flags: --max_old_space_size=4096 at new NodeError (internal/errors.js:322:7) at new Worker (internal/worker.js:196:13) at ExperimentalWorker.initialize (C:\Users\ed\IdeaProjects\assist2-web\node_modules\jest-worker\build\workers\NodeThreadsWorker.js:149:20) at new ExperimentalWorker (C:\Users\ed\IdeaProjects\assist2-web\node_modules\jest-worker\build\workers\NodeThreadsWorker.js:145:10) at WorkerPool.createWorker (C:\Users\ed\IdeaProjects\assist2-web\node_modules\jest-worker\build\WorkerPool.js:44:12) at new BaseWorkerPool (C:\Users\ed\IdeaProjects\assist2-web\node_modules\jest-worker\build\base\BaseWorkerPool.js:127:27) at new WorkerPool (C:\Users\ed\IdeaProjects\assist2-web\node_modules\jest-worker\build\WorkerPool.js:30:1) at new Worker (C:\Users\ed\IdeaProjects\assist2-web\node_modules\jest-worker\build\index.js:167:26) at getWorker (C:\Users\ed\IdeaProjects\assist2-web\node_modules\css-minimizer-webpack-plugin\dist\index.js:192:29) at C:\Users\ed\IdeaProjects\assist2-web\node_modules\css-minimizer-webpack-plugin\dist\index.js:262:41

simplejason · 2021-11-30T07:23:54Z

I faced same error in angular 12 cli, and also it was proved that the problem was caused by 27.4.0:

styles.40679d291cbf2b600aeb.css - Error: styles.40679d291cbf2b600aeb.css from Css Minimizer
Error [ERR_WORKER_INVALID_EXEC_ARGV]: Initiated Worker with invalid execArgv flags: --max_old_space_size=4096
    at new NodeError (internal/errors.js:322:7)
    at new Worker (internal/worker.js:196:13)
    at ExperimentalWorker.initialize (/home/vsts/work/1/s/node_modules/jest-worker/build/workers/NodeThreadsWorker.js:149:20)
    at new ExperimentalWorker (/home/vsts/work/1/s/node_modules/jest-worker/build/workers/NodeThreadsWorker.js:145:10)
    at WorkerPool.createWorker (/home/vsts/work/1/s/node_modules/jest-worker/build/WorkerPool.js:44:12)
    at new BaseWorkerPool (/home/vsts/work/1/s/node_modules/jest-worker/build/base/BaseWorkerPool.js:127:27)
    at new WorkerPool (/home/vsts/work/1/s/node_modules/jest-worker/build/WorkerPool.js:30:1)
    at new Worker (/home/vsts/work/1/s/node_modules/jest-worker/build/index.js:167:26)
    at getWorker (/home/vsts/work/1/s/node_modules/css-minimizer-webpack-plugin/dist/index.js:192:29)
    at /home/vsts/work/1/s/node_modules/css-minimizer-webpack-plugin/dist/index.js:262:41
    at /home/vsts/work/1/s/node_modules/css-minimizer-webpack-plugin/node_modules/p-limit/index.js:23:31
    at run (/home/vsts/work/1/s/node_modules/css-minimizer-webpack-plugin/node_modules/p-limit/index.js:23:43)
    at /home/vsts/work/1/s/node_modules/css-minimizer-webpack-plugin/node_modules/p-limit/index.js:45:20

SimenB · 2021-11-30T08:38:41Z

https://github.com/facebook/jest/releases/tag/v27.4.1

JonWallsten · 2021-11-30T09:50:11Z

@kherock @SimenB: According to Node's official documentation hyphens are supposed to be used, not undescore. We used underscore before but are now using hyphens. Can we patch both?
Source:
https://nodejs.org/api/cli.html#cli_max_old_space_size_size_in_megabytes

SimenB · 2021-11-30T09:56:33Z

PR welcome

SuperOleg39 · 2021-11-30T11:27:21Z

This seems fine to me. I'd suggest adding a unit test assertion for this, there's a similar one you can borrow testing --inspect in the child process worker test file.

Didn't get to add test(

https://github.com/facebook/jest/releases/tag/v27.4.1

Thanks!

According to Node's official documentation hyphens are supposed to be used, not undescore. We used underscore before but are now using hyphens. Can we patch both?

Good catch, thanks!

github-actions · 2021-12-31T00:05:17Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

jest-worker: Avoid crash when "--max-old-space-size" inside process.e…

9431272

…xecArgv

facebook-github-bot added the cla signed label Nov 29, 2021

kherock reviewed Nov 29, 2021

View reviewed changes

simplejason mentioned this pull request Nov 30, 2021

chore(release): release 12.1.0 NG-ZORRO/ng-zorro-antd#7087

Merged

3 tasks

SimenB added 3 commits November 30, 2021 08:56

Update NodeThreadsWorker.ts

a595705

eslint and changelog

b110748

comment

113e317

SimenB changed the title ~~jest-worker: Avoid crash when "--max-old-space-size" inside process.execArgv~~ jest-worker: Avoid crash when "--max-old-space-size" inside process.execArgv Nov 30, 2021

SimenB merged commit 7fead59 into jestjs:main Nov 30, 2021

JonWallsten mentioned this pull request Nov 30, 2021

jest-worker: Avoid crash when "--max-old-space-size" inside process.execArgv #12103

Merged

pbrisbin mentioned this pull request Nov 30, 2021

Bump jest from 27.3.1 to 27.4.2 freckle/commenter-action#91

Merged

This was referenced Nov 30, 2021

chore(deps-dev): bump jest from 26.6.3 to 27.4.2 nodebots/nodebots-interchange#211

Closed

chore(deps-dev): bump jest from 26.6.3 to 27.4.3 nodebots/nodebots-interchange#212

Closed

github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

jest-worker: Avoid crash when "--max-old-space-size" inside `process.execArgv` #12097

jest-worker: Avoid crash when "--max-old-space-size" inside `process.execArgv` #12097

SuperOleg39 commented Nov 29, 2021 •

edited

Loading

SuperOleg39 commented Nov 29, 2021

SuperOleg39 commented Nov 29, 2021

codecov-commenter commented Nov 29, 2021

kherock left a comment •

edited

Loading

poman31 commented Nov 29, 2021

simplejason commented Nov 30, 2021

SimenB commented Nov 30, 2021

JonWallsten commented Nov 30, 2021

SimenB commented Nov 30, 2021

SuperOleg39 commented Nov 30, 2021

github-actions bot commented Dec 31, 2021

jest-worker: Avoid crash when "--max-old-space-size" inside process.execArgv #12097

jest-worker: Avoid crash when "--max-old-space-size" inside process.execArgv #12097

Conversation

SuperOleg39 commented Nov 29, 2021 • edited Loading

SuperOleg39 commented Nov 29, 2021

SuperOleg39 commented Nov 29, 2021

codecov-commenter commented Nov 29, 2021

Codecov Report

kherock left a comment • edited Loading

Choose a reason for hiding this comment

poman31 commented Nov 29, 2021

simplejason commented Nov 30, 2021

SimenB commented Nov 30, 2021

JonWallsten commented Nov 30, 2021

SimenB commented Nov 30, 2021

SuperOleg39 commented Nov 30, 2021

github-actions bot commented Dec 31, 2021

jest-worker: Avoid crash when "--max-old-space-size" inside `process.execArgv` #12097

jest-worker: Avoid crash when "--max-old-space-size" inside `process.execArgv` #12097

SuperOleg39 commented Nov 29, 2021 •

edited

Loading

kherock left a comment •

edited

Loading