Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add note about retryTimes placement #12212

Merged
merged 2 commits into from
Feb 5, 2022

Conversation

Michael-M-Judd
Copy link
Contributor

Summary

Updated the docs to be clear around where to put jest.retryTimes. This may sound simple but we thought retries were working but we had them in a beforeEach block which doesn't trigger retries.

Test plan

N/A

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! could you update the versioned docs as well?

image

website/versioned_docs/version-27.4/JestObjectAPI.md Outdated Show resolved Hide resolved
@Michael-M-Judd Michael-M-Judd requested a review from SimenB January 13, 2022 18:37
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB changed the title chore(JestObjectAPI.md): add note about retryTimes placement chore(docs): add note about retryTimes placement Feb 5, 2022
@SimenB SimenB merged commit 4715c09 into jestjs:main Feb 5, 2022
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants