-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop node 10 and node 15 #12220
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12220 +/- ##
==========================================
- Coverage 67.31% 67.29% -0.02%
==========================================
Files 329 329
Lines 17336 17327 -9
Branches 5074 5071 -3
==========================================
- Hits 11669 11660 -9
Misses 5634 5634
Partials 33 33
Continue to review full report at Codecov.
|
Possible candidate for Node 10 support clean up: |
Ah, good call! |
@@ -74,27 +74,22 @@ function find( | |||
callback(result); | |||
return; | |||
} | |||
// node < v10.10 does not support the withFileTypes option, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's another node 10 thing below we could simplify, but I'm not 100% sure what the correct solution is there (https://github.com/facebook/jest/pull/9514/files/9f0aae7c79090cc5275aa7b91e2bb5a02d2c36f0#r800046825)
10ea2d8
to
b4bf20c
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
They're both EOL.
Also set range of Node 16 version to first LTS release.
Test plan
Green CI