Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-snapshot): migrate to ESM #12342

Merged
merged 4 commits into from
Feb 9, 2022
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 9, 2022

Summary

Bundling doesn't like export =, so let's get rid of it.

I also cleanup up the exports a bit (not exporting utils)

Test plan

Green CI

@codecov-commenter
Copy link

Codecov Report

Merging #12342 (ae60d1b) into main (f2e3040) will increase coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12342   +/-   ##
=======================================
  Coverage   66.97%   66.97%           
=======================================
  Files         329      329           
  Lines       17338    17336    -2     
  Branches     5066     5066           
=======================================
- Hits        11612    11611    -1     
+ Misses       5694     5693    -1     
  Partials       32       32           
Impacted Files Coverage Δ
...circus/src/legacy-code-todo-rewrite/jestAdapter.ts 0.00% <ø> (ø)
...us/src/legacy-code-todo-rewrite/jestAdapterInit.ts 0.00% <0.00%> (ø)
packages/jest-jasmine2/src/index.ts 0.00% <0.00%> (ø)
packages/jest-jasmine2/src/setup_jest_globals.ts 0.00% <0.00%> (ø)
packages/jest-runtime/src/index.ts 55.32% <ø> (ø)
packages/jest-core/src/TestScheduler.ts 81.08% <100.00%> (ø)
packages/jest-snapshot/src/index.ts 78.75% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2e3040...ae60d1b. Read the comment docs.

@SimenB SimenB merged commit 54bfc1c into jestjs:main Feb 9, 2022
@SimenB SimenB deleted the jest-snapshot-no-export branch February 9, 2022 14:46
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants