refactor(jest-runtime): do not import from @jest/globals
#12411
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently
jest-runtime
is importing types from@jest/globals
, seems like there is no need for that. All necessary types can be imported directly.The only change –
@jest/globals
is removed fromjest-runtime
dependency graph.Semi-related idea. If this change is accepted, none of the packages in the repo will depend on
@jest/globals
. What if the code of@jest/globals
would be moved intojest
? Just wondering, if the guide for typed testing could look like this:yarn add -D jest
import {expect, jest, test} from 'jest';
Test plan
Green CI