Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contexts to mocks #12601

Merged
merged 17 commits into from
Mar 29, 2022
Merged

Add contexts to mocks #12601

merged 17 commits into from
Mar 29, 2022

Conversation

matthias-ccri
Copy link
Contributor

@matthias-ccri matthias-ccri commented Mar 24, 2022 •
edited
Loading

Summary

Add a context member to mocks. See #11235

Test plan

Unit tests

@facebook-github-bot
Copy link
Contributor

Hi @matthias-ccri!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@matthias-ccri matthias-ccri mentioned this pull request Mar 24, 2022
Closed
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

mrazauskas
mrazauskas reviewed Mar 25, 2022
View reviewed changes
website/versioned_docs/version-25.x/JestObjectAPI.md Outdated
@@ -560,7 +560,7 @@ test('plays audio', () => {

### `jest.clearAllMocks()`

Clears the `mock.calls`, `mock.instances` and `mock.results` properties of all mocks. Equivalent to calling [`.mockClear()`](MockFunctionAPI.md#mockfnmockclear) on every mocked function.
Clears the `mock.calls`, `mock.instances`, `mock.contexts` and `mock.results` properties of all mocks. Equivalent to calling [`.mockClear()`](MockFunctionAPI.md#mockfnmockclear) on every mocked function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should work with files from /docs directory. These are the ones for future releases. The docs under /website directory are for previous versions of Jest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, I'll update the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

SimenB
SimenB approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff, thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
packages/jest-mock/__typetests__/mock-functions.test.ts Outdated Show resolved Hide resolved
SimenB
SimenB reviewed Mar 25, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
SimenB
SimenB approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB linked an issue Mar 25, 2022 that may be closed by this pull request
Testing function context ("this") in Mock functions #11235
Closed
@SimenB
Copy link
Member

SimenB commented Mar 25, 2022

Type test is failing. You can run it via yarn test-types packages/jest-mock/__typetests__/mock-functions.test.ts

@matthias-ccri
Copy link
Contributor Author

The type tests are passing now for me locally. Thanks for the catch. In my IDE that file is lit up with red errors so I wasn't sure what I caused. Anyway, yarn test-types should pass now.

SimenB
SimenB reviewed Mar 25, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
mrazauskas
mrazauskas reviewed Mar 26, 2022
View reviewed changes
docs/MockFunctionAPI.md Outdated Show resolved Hide resolved
@matthias-ccri @mrazauskas
Combine contexts type assertion into one line
fd61630 
Co-authored-by: Tom Mrazauskas <tom@mrazauskas.de>
@SimenB SimenB changed the title Add contexts to mocks (https://github.com/facebook/jest/issues/11235) Add contexts to mocks Mar 29, 2022
@SimenB SimenB merged commit f496a93 into jestjs:main Mar 29, 2022
@SimenB
Copy link
Member

SimenB commented Mar 29, 2022

Thanks @matthias-ccri!

@mrazauskas mrazauskas mentioned this pull request Apr 2, 2022
Merged
@SimenB
Copy link
Member

SimenB commented Apr 5, 2022

https://github.com/facebook/jest/releases/tag/v28.0.0-alpha.8

@github-actions
Copy link

github-actions bot commented May 6, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrazauskas mrazauskas mrazauskas left review comments

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing function context ("this") in Mock functions
4 participants
@matthias-ccri @facebook-github-bot @SimenB @mrazauskas