Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): use lite embed instead of iframe for YouTube videos #12643

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 7, 2022

Summary

Hopefully this fixes the broken website deploy: #12572 (comment)

Test plan

Check out preview

@@ -1,127 +0,0 @@
/**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused 🤷

@SimenB
Copy link
Member Author

SimenB commented Apr 7, 2022

It's faster when loading index page, so let's try

deployment preview:
image
current site:
image

@SimenB SimenB merged commit c12d444 into jestjs:main Apr 7, 2022
@SimenB SimenB deleted the use-youtube-embed-over-iframe branch April 7, 2022 10:33
@github-actions
Copy link

github-actions bot commented May 8, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants