Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: rootdir affects preset resolution #12817

Merged
merged 3 commits into from
May 13, 2022
Merged

Doc: rootdir affects preset resolution #12817

merged 3 commits into from
May 13, 2022

Conversation

dimitropoulos
Copy link
Contributor

Summary

The docs do not mention that rootDir can change the resolution of the preset. See #11399 (comment) for an example.

Additionally, I noticed that the docs were referring to a jest preset javascript file, yet showing JSON. Fixed that as well.

Test plan

n/a

@facebook-github-bot
Copy link
Contributor

Hi @dimitropoulos!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

SimenB
SimenB approved these changes May 8, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! could you also update https://github.com/facebook/jest/blob/main/docs/Configuration.md and https://github.com/facebook/jest/blob/main/website/versioned_docs/version-28.0/Configuration.md?

website/versioned_docs/version-28.1/Configuration.md Show resolved Hide resolved
@dimitropoulos
Copy link
Contributor Author

@SimenB thanks: wasn't sure which other files to update. Should be good to go on all 3 files now.

@dimitropoulos
Copy link
Contributor Author

what are the next steps on getting this merged?

@SimenB SimenB merged commit 7b6da60 into jestjs:main May 13, 2022
@dimitropoulos dimitropoulos mentioned this pull request May 13, 2022
Merged
@dimitropoulos dimitropoulos deleted the fix/preset-docs branch May 13, 2022 16:46
@mrazauskas mrazauskas mentioned this pull request May 15, 2022
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrazauskas mrazauskas mrazauskas left review comments

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dimitropoulos @facebook-github-bot @SimenB @mrazauskas