Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): make writefile path compatible posix and windows system #13270

Merged
merged 4 commits into from
Sep 17, 2022

Conversation

weidehai
Copy link
Contributor

@weidehai weidehai commented Sep 16, 2022

Summary

make writefile path compatible posix and windows system

Closes #13204

Test plan

Copy link
Contributor

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB I can confirm the build error and that this fixes it

(my local had gotten confused because my fork was made before the repo switched to main 🙄)

scripts/bundleTs.mjs Outdated Show resolved Hide resolved
Co-authored-by: Gareth Jones <Jones258@Gmail.com>
Comment on lines 203 to 204
const {sep} = path;
const replaceDirReg = new RegExp(`(?<=\\${sep})(dist)(?=\\${sep})`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB you'll need to remove this line too

Suggested change
const {sep} = path;
const replaceDirReg = new RegExp(`(?<=\\${sep})(dist)(?=\\${sep})`);
const {sep} = path;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes,i remove it😊

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB changed the title fix: make writefile path compatible posix and windows system chore(build): make writefile path compatible posix and windows system Sep 17, 2022
@SimenB SimenB merged commit 60e6870 into jestjs:main Sep 17, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants