Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add typecheck for expect tests #13383

Merged
merged 11 commits into from
Oct 4, 2022
Merged

chore: add typecheck for expect tests #13383

merged 11 commits into from
Oct 4, 2022

Conversation

mrazauskas
Copy link
Contributor

Summary

Test of expect package got reworked and clean up. Almost ready to be typechecked. I have to deal with a couple of details (see comments).

Test plan

Green CI.

tsconfig.test.json Outdated Show resolved Hide resolved
@mrazauskas mrazauskas marked this pull request as ready for review October 4, 2022 18:03
@@ -69,6 +64,17 @@ declare module '../types' {
}
}

const jestExpect = importedExpect as typeof importedExpect & {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case typings have to be added like this. TypeScript is not happy about merging declaration of AsymmetricMatchers interface – it goes looking for expect object in ../index.ts, does not find properties from the declaration and complains.

@mrazauskas
Copy link
Contributor Author

Typecheck passed. Yes!

That was quite some job. But in the end I am very happy about those tiny changes and improvement which were brought to Jest types.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great job! Will be interesting how many will error once linting is turned off (which will yell at all anys 😀)

@SimenB SimenB merged commit c660c16 into jestjs:main Oct 4, 2022
@mrazauskas mrazauskas deleted the chore-expect-tests-typecheck branch October 4, 2022 19:30
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants