-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarify wording in GettingStarted.md #13447
Conversation
Fix 1 word to avoid confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you update all versions of this doc? 🙂
|
Could you combine the PRs? 😅 Just cleaner in git history. We squash on merge, so feel free to stack the commits |
Sorry, I don't know how to do that. Would it be better if I deleted the existing requests and do it in one pull request? |
from this branch ( No need for a new PR 👍 |
Hi @waikoo! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
@waikoo OK, I've merged them now 🙂 It seems the CLA bot didn't run until now. Could you sign in? |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fix 1 word to avoid confusion
Summary
Changed "Jest does not fully supported by vite..." to "Jest is not fully supported by vite..." because the original version's first 4 words lead the reader to believe that it's Jest that's not supporting Vite... until you make out later from the context that the reason for Jest not being supported is due to Vite's plugin system.
Test plan
No code, just grammar.