fix: Strict equality for errors and throws custom classes #13607
Conversation
| return a.message == b.message; | ||
| // Compare just error messages only if not strict check | ||
| if (!strictCheck) return a.message == b.message; | ||
| if (a.message != b.message) return false; |
There was a problem hiding this comment.
this seems somewhat odd to me - should we stop comparing Errors unless their message matches? Is the thought that we want to treat that as any other objects?
There was a problem hiding this comment.
With the previous implementation, the discriminant determining Errors equality was only the message field.
With this implementation, you compare only the messages for non-strict equality, and you treat the two objects as any other object for strict equality checks.
It probably depends on how you think strict equality should be intended for Error objects.
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
fix #13604
ErrortoThrow