Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

single jest run for all packages #1361

Merged
merged 2 commits into from
Aug 4, 2016
Merged

single jest run for all packages #1361

merged 2 commits into from
Aug 4, 2016

Conversation

aaronabramov
Copy link
Contributor 

488 tests passed (488 total in 62 test suites, 9 snapshots, run time 30.878s)

@ghost ghost added the CLA Signed ✔️ label Aug 3, 2016
@ghost ghost added the CLA Signed ✔️ label Aug 3, 2016
@cpojer
Copy link
Member

cpojer commented Aug 4, 2016

Seems like this is currently failing for awkward reasons.

cpojer
cpojer reviewed Aug 4, 2016
View reviewed changes
packages/jest-runtime/src/__tests__/__snapshots__/transform-test.js.snap
@@ -1,25 +1,25 @@
exports[`transform transforms a file properly 1`] = `
"({\"Object.<anonymous>\":function(module,exports,require,__dirname,__filename,global,jest){module.exports = \"banana\";
"({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){module.exports = "banana";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fairly convinced that this shouldn't be happening. Do you have an older version of pretty-format locally? Can you do npm run clean and npm install? The quotes should definitely be escaped.

@cpojer
Copy link
Member

cpojer commented Aug 4, 2016

Ok yeah, this does make a ton of sense. I love how you both created and fixed this mess :) Let's polish it up and make sure the snapshot tests do what we expect them to do.

cpojer
cpojer reviewed Aug 4, 2016
View reviewed changes
package.json
"jest": {
"rootDir": "./",
"scriptPreprocessor": "<rootDir>/packages/babel-jest",
"automock": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was on my todo list. NICEEE

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please alphabetize the items in this config.

@ghost ghost added the CLA Signed ✔️ label Aug 4, 2016
@ghost ghost added the CLA Signed ✔️ label Aug 4, 2016
@ghost ghost added the CLA Signed ✔️ label Aug 4, 2016
@aaronabramov
Copy link
Contributor Author

  1. I ignored building of __test__ files as we don't really need them anymore. everything is run through babel-jest
  2. I had to split RequireModuleOrMock tests into two, because it's really fat and it's been timing out multiple times for the last two weeks. We should invest more into understanding why it happens though, it might be a serious performance issue
  3. More CLI UI magic

@aaronabramov aaronabramov merged commit 6c76202 into jestjs:master Aug 4, 2016
@aaronabramov aaronabramov deleted the single-jest branch August 4, 2016 22:09
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronabramov @cpojer @facebook-github-bot