-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stop changing the behaviour of spies on mockFn.mockReset #13692
Conversation
Can you add e2e tests that verify that this behavior is working and add a line to the CHANGELOG.md? |
Should probably update the docs as well to specify what we're skipping? |
The linked issue is pointing to a note from this line of documentaion: I guess the text in parenthesis should be deleted, or? |
Thanks @mrazauskas |
@feliperli there's a type error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
The motivation described at this issue is to instead of returning undefined for
mockReset
return the original function itself.Test plan