Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use prettier as default formatter in vscode #13721

Merged
merged 2 commits into from
Jan 3, 2023
Merged

chore: use prettier as default formatter in vscode #13721

merged 2 commits into from
Jan 3, 2023

Commits on Jan 3, 2023

  1. chore: use prettier as default formatter in vscode 

    This helps contributors to use the right formatter to avoid messing up the style
    @unional
    unional committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    dac3ed3 View commit details
    Browse the repository at this point in the history

  2. chore: add ts.format config 

    Since prettier is used as the default formatter,
these setting only affects "organize import" command.
Which is what we want.

It doesn't work completely, as this:

```ts
import type {
  JestHookSubscriber,
  UpdateConfigCallback,
  UsageData,
  WatchPlugin,
} from './types';
```

will be formatted as:

```ts
import type {
  JestHookSubscriber,
  UpdateConfigCallback,
  UsageData,
  WatchPlugin   // <-- comma removed
} from './types';
```

Running format doc (prettier) will fix that.
It is better than not having it.
    @unional
    unional committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    12361f5 View commit details
    Browse the repository at this point in the history