Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing package.json type to tsIntegration tests #13743

Merged
merged 1 commit into from
Jan 8, 2023

Conversation

MasterOdin
Copy link
Contributor

@MasterOdin MasterOdin commented Jan 8, 2023

Summary

PR updates two tests in tsIntegration.test.ts to use type: "module" in the package.json where the description says when package.json#type=module but the test did not actually set that. This makes these tests look identical to the tests above that have that same suffix.

I noticed this while working on #13742

Test plan

That CI passes, or by doing:

$ yarn jest -c jest.config.ts.mjs e2e/__tests__/tsIntegration.test.ts
 PASS   ts-integration  e2e/__tests__/tsIntegration.test.ts (9.98 s)
  when `Config` type is imported from "@jest/types"
    ✓ with object config exported from TS file (623 ms)
    ✓ with function config exported from TS file (708 ms)
    ✓ throws if type errors are encountered (576 ms)
    ✓ throws if syntax errors are encountered (567 ms)
    ✓ works with object config exported from TS file when package.json#type=module (577 ms)
    ✓ works with function config exported from TS file when package.json#type=module (594 ms)
    ✓ throws if type errors are encountered when package.json#type=module (565 ms)
    ✓ throws if syntax errors are encountered when package.json#type=module (559 ms)
  when `Config` type is imported from "jest"
    ✓ with object config exported from TS file (620 ms)
    ✓ with function config exported from TS file (664 ms)
    ✓ throws if type errors are encountered (600 ms)
    ✓ throws if syntax errors are encountered (620 ms)
    ✓ works with object config exported from TS file when package.json#type=module (639 ms)
    ✓ works with function config exported from TS file when package.json#type=module (644 ms)
    ✓ throws if type errors are encountered when package.json#type=module (611 ms)
    ✓ throws if syntax errors are encountered when package.json#type=module (666 ms)

Test Suites: 1 passed, 1 total
Tests:       16 passed, 16 total
Snapshots:   0 total
Time:        10.146 s, estimated 13 s
Ran all test suites matching /e2e\/__tests__\/tsIntegration.test.ts/i

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants