-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babel option rename (blacklist -> denylist) #14109
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Does this mean we need to adjust some peer deps for older versions of v7? DefinitelyTyped/DefinitelyTyped#49229 😀 |
Oh right :) It has been released in v7.11.0, while Jest has a peerDependency on 7.0.0 (
jest/packages/babel-jest/package.json Line 35 in d91ab8e
There is no rush for this PR, we can wait until Jest 30 is ready (or even later!). |
Let's land it for 30 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Babel currently has two names for the same option (blacklist and denylist); we are going to remove on in Babel 8. This should fix the Babel 8 error in babel/babel#15576.