Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade TypeScript to v5 #14155

Merged
merged 3 commits into from
May 24, 2023
Merged

chore: upgrade TypeScript to v5 #14155

merged 3 commits into from
May 24, 2023

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented May 24, 2023

Summary

it's new(ish) and fresh(ish)

Test plan

Green CI

@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1765c52
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/646e06d0e96e200008bb5dbe
😎 Deploy Preview https://deploy-preview-14155--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@SimenB
Copy link
Member Author

SimenB commented May 24, 2023

@mrazauskas thoughts on the error?

@mrazauskas
Copy link
Contributor

mrazauskas commented May 24, 2023

Looks like TS is pointing to makeTemplate():

jest/e2e/Utils.ts

Lines 93 to 94 in 8403030

export const makeTemplate =
(str: string): ((values?: Array<unknown>) => string) =>

Typecheck is passing if I change typings of the signature like this:

- (str: string): ((values?: Array<unknown>) => string) =>
+ (str: string): ((values?: Array<string>) => string) =>

EDIT I looked though the tests which use makeTemplate(). There are no type errors because of this change. Perhaps values?: Array<string> is good enough for now?

@SimenB
Copy link
Member Author

SimenB commented May 24, 2023

Yeah, that looks more correct as well

@SimenB SimenB merged commit 6ffa48d into jestjs:main May 24, 2023
@SimenB SimenB deleted the upgrade-ts branch May 24, 2023 13:42
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants