-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jest-config): allow coverageDirectory and collectCoverageFrom in project config #14180
fix(jest-config): allow coverageDirectory and collectCoverageFrom in project config #14180
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Edit: it was just an old empty folder that was causing issues. Ooops!
Full Output
|
This fix only solves the issue for 2 of the options. Why not fix it for everything that is now suddenly giving these errors? E.g., "reporters" is another option that gives this warning and still works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Completely agree. @SimenB Can you take a look? |
I can confirm the issue is fixed after updating jest to 29.6.0! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
jest currently warns that coverageDirectory and collectCoverageFrom as a global only option, when configured at the project level config. But the project level configuration still applies the value.
Test plan
existing tests pass
Note: this is in reference #13576
Where options are validated as invalid for the project level potentially incorrectly. There are other options that are also warned about, but the two added here are at least known to still work on the project level and appear to be used in most cases.
before
with change