Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency write-file-atomic to v5 #14274

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 26, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
write-file-atomic ^4.0.2 -> ^5.0.0 age adoption passing confidence

Release Notes

npm/write-file-atomic (write-file-atomic)

v5.0.1

Compare Source

Dependencies

v5.0.0

Compare Source

⚠️ BREAKING CHANGES
  • write-file-atomic is now compatible with the following semver range for node: ^14.17.0 || ^16.13.0 || >=18.0.0
Features

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for jestjs ready!

Name Link
🔨 Latest commit b9b8978
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/653fb4da9f38c10008fc6a6b
😎 Deploy Preview https://deploy-preview-14274--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB
Copy link
Member

SimenB commented Jun 27, 2023

See #13853 - need to wait for v30

@SimenB SimenB added this to the Jest 30 milestone Jun 27, 2023
@Jolg42
Copy link

Jolg42 commented Oct 30, 2023

Hello @SimenB
I just noticed you released https://github.com/jestjs/jest/releases/tag/v30.0.0-alpha.1 - I'm very curious to try it!
On that topic, could you add this to the v30 pre-release?

I don't see a branch where this PR would need to go at the moment.

My colleague reported that on Node.js v21 he got this error, which I think will likely be fixed by the upgrade:

TypeError: Jest: Got error running globalSetup - /Users/aqrln/prisma/prisma/packages/client/tests/functional/_utils/globalSetup.js, reason: jest: failed to cache transform results in: /private/var/folders/54/8s4kj7mx4nn4tv4jl9y9yzkr0000gn/T/jest_dx/jest-transform-cache-bb99237c3d938d836a317f0c1757a3da-79ef2876fae7ca75eedb2aa53dc48338/a0/index_a0803b5da29570874c6c059f7e179abe
Failure message: onExit is not a function
    at writeFileSync (/Users/aqrln/prisma/prisma/node_modules/.pnpm/write-file-atomic@4.0.2/node_modules/write-file-atomic/lib/index.js:212:31)
    at writeCacheFile (/Users/aqrln/prisma/prisma/node_modules/.pnpm/@jest+transform@29.7.0/node_modules/@jest/transform/build/ScriptTransformer.js:908:33)
    at writeCodeCacheFile (/Users/aqrln/prisma/prisma/node_modules/.pnpm/@jest+transform@29.7.0/node_modules/@jest/transform/build/ScriptTransformer.js:875:3)
    at ScriptTransformer._buildTransformResult (/Users/aqrln/prisma/prisma/node_modules/.pnpm/@jest+transform@29.7.0/node_modules/@jest/transform/build/ScriptTransformer.js:514:5)
    at ScriptTransformer.transformSource (/Users/aqrln/prisma/prisma/node_modules/.pnpm/@jest+transform@29.7.0/node_modules/@jest/transform/build/ScriptTransformer.js:554:17)
    at revertHook.exts (/Users/aqrln/prisma/prisma/node_modules/.pnpm/@jest+transform@29.7.0/node_modules/@jest/transform/build/ScriptTransformer.js:776:18)
    at Module._compile (/Users/aqrln/prisma/prisma/node_modules/.pnpm/pirates@4.0.5/node_modules/pirates/lib/index.js:130:29)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Object.newLoader (/Users/aqrln/prisma/prisma/node_modules/.pnpm/pirates@4.0.5/node_modules/pirates/lib/index.js:141:7)
    at Module.load (node:internal/modules/cjs/loader:1207:32)

@Jolg42
Copy link

Jolg42 commented Oct 30, 2023

I guess, it would need to be merged as is, because the main branch is what got released to v30 pre-release from what I understand.

@SimenB
Copy link
Member

SimenB commented Oct 30, 2023

Yeah, we release from main 🙂


I haven't noticed any issues on Jest's CI running on v21 - do you have a reproduction?

@renovate
Copy link
Contributor Author

renovate bot commented Oct 30, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@SimenB SimenB enabled auto-merge (squash) October 30, 2023 13:51
@Jolg42
Copy link

Jolg42 commented Oct 30, 2023

Thanks for the quick answer 💚

@aqrln, that I forgot to mention here, might have a reproduction.
Maybe an easy and low-effort way to try this would be to add this to the next pre-release and then see if the problem is fixed.
Do you need a reproduction now, or is it ok to only provide it after the update & trying the next pre-release, in case the problem persists?

@SimenB
Copy link
Member

SimenB commented Oct 30, 2023

I'm fine with just landing this. I'm just curious how such an error can be present 😅

@SimenB SimenB merged commit 59af15e into main Oct 30, 2023
73 checks passed
@SimenB SimenB deleted the renovate/write-file-atomic-5.x branch October 30, 2023 15:09
@Jolg42
Copy link

Jolg42 commented Oct 30, 2023

Note: jest --clearCache helped (without upgrading).

@SimenB
Copy link
Member

SimenB commented Nov 16, 2023

https://github.com/jestjs/jest/releases/tag/v30.0.0-alpha.2

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants