Fix skipped and todo tests in Github Actions Reporter #14309
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/jest-reporters/src/__tests__/GitHubActionsReporter.test.ts
Outdated
Show resolved
Hide resolved
packages/jest-reporters/src/__tests__/GitHubActionsReporter.test.ts
Outdated
Show resolved
Hide resolved
MatteoH2O1999
force-pushed
the
fix-gha
branch
2 times, most recently
from
141764a
to
c3afed2
Compare
| Test, | ||
| TestCaseResult, | ||
| TestResult, | ||
| } from '@jest/test-result'; | ||
| import type {Config} from '@jest/types'; | ||
| import GitHubActionsReporter from '../GitHubActionsReporter'; | ||
| import {normalizeIcons} from '../../../../e2e/Utils'; |
There was a problem hiding this comment.
Can you move this helper to @jest/test-utils?
There was a problem hiding this comment.
I would probably do that in another PR though
There was a problem hiding this comment.
Would be good to this now. @jest/test-utils is an internal package.
|
Conflict solved |
e2e/Utils.ts
Outdated
|
|
||
| export {normalizeIcons} from '@jest/test-utils'; |
There was a problem hiding this comment.
The reexport is unnecessary. This util is part of the internal testing infrastructure, it isn’t a public API.
| export {normalizeIcons} from '@jest/test-utils'; |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #14278
Test plan
Added relevant unit tests