fix(jest-snapshot): move @types/prettier to devDependencies #14328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…typescript projects using prettier >2.1.5
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
SimenB
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
This is correct as the types are not used in the exported types: https://www.runpkg.com/?jest-snapshot@29.6.1/build/index.d.ts
This was referenced Aug 2, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
@types/prettiertodevDependenciesto avoid conflicts with typescript projects usingprettier>2.1.5.Summary
I've been working on a project that uses TypeScript and Prettier directly, while working with it there were a few issues regarding the types (
checkandformatfunctions).I'm using
prettier@3.xandjest@29.6.1for testing. After getting some warnings about the types on my IDE, and given that prettier already ships it's own types I decided to check around, turns out thatjest-snapshotwas listing@types/prettieras a dependency. Not only that, but it'sprettier@2.xso that were giving me erroneous warnings and IDE hints.I don't see a reason to have
@types/prettieras adependencyinstead of adevDependencyso...Test plan