-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: opt jest codebase #14366
chore: opt jest codebase #14366
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/jest-util/src/invariant.ts
Outdated
|
||
export default function invariant( | ||
condition: unknown, | ||
message?: string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to make the message required. Also it would be nice to append "This is a bug in Jest...", like here:
jest/packages/jest-runtime/src/index.ts
Line 530 in 0fd5b1c
`Module cache already has entry ${cacheKey}. This is a bug in Jest, please report it!`, |
jest/packages/jest-runtime/src/index.ts
Line 546 in 0fd5b1c
'Module cache does not contain module. This is a bug in Jest, please open up an issue', |
invariant()
is used in places there value is defined, but TypeScript cannot see that. So a failure is definitely a bug, that is why it makes sense to append "This is a bug in Jest..."
By the way, it could be good default message (instead of making the message required).
Sorry, I was wrong. Apparently |
@mrazauskas I've try some methods to fix CI, and it did not work. Now I need your help. Is there any suggestions or methods to fix the broken CI. The informations is above:
and
more details in link. Thanks any more. |
This is flaky test. Just ignore it. Not related with your changes. |
Can this pr be merged, if no other problems ? cc @SimenB @mrazauskas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This pr is optimize code base. Including
jest-runtime
,jest-changed-files
andjest-core
and so on.Test plan