Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expect): remove @types/node from dependencies #14385

Merged
merged 3 commits into from
Aug 16, 2023
Merged

fix(expect): remove @types/node from dependencies #14385

merged 3 commits into from
Aug 16, 2023

Conversation

dmitri-gb
Copy link
Contributor

@dmitri-gb dmitri-gb commented Aug 3, 2023 •
edited
Loading

Summary

Remove @types/node from dependencies of expect. This package can be used in non-Node.js environments.

The dependency was introduced in #14139.

@netlify
Copy link

netlify bot commented Aug 3, 2023 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 72bf413
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/64db3687c22a3100077e535d
😎 Deploy Preview https://deploy-preview-14385--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dmitri-gb dmitri-gb changed the title fix(expect): remove dependency on a Node.js module fix(expect): remove @types/node from dependencies Aug 3, 2023
mrazauskas
mrazauskas reviewed Aug 4, 2023
View reviewed changes
packages/expect/src/types.ts
Comment on lines -61 to +60
currentConcurrentTestName?: AsyncLocalStorage<string>;
currentConcurrentTestName?: () => string | undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like breaking change, or?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. Not sure if it's breaking enough, tho... 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, breaking for anyone that calls jestExpect.setState with this property or anyone that reads it inside a custom matcher. Since the property was only added in v29.6.0 then I'm pretty sure only Jest itself does that 😅

@mrazauskas mrazauskas mentioned this pull request Aug 16, 2023
Closed
@SimenB SimenB linked an issue Aug 16, 2023 that may be closed by this pull request
[Bug]: "expect" package now imports @types/node causing web projects to break #14418
Closed
@SimenB SimenB merged commit 0cbe04d into jestjs:main Aug 16, 2023
89 checks passed
@SimenB
Copy link
Member

SimenB commented Aug 21, 2023

https://github.com/jestjs/jest/releases/tag/v29.6.3

This was referenced Aug 28, 2023
Draft
Draft
Draft
Draft
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrazauskas mrazauskas mrazauskas left review comments

@SimenB SimenB SimenB left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: "expect" package now imports @types/node causing web projects to break
3 participants
@dmitri-gb @SimenB @mrazauskas