fix: comparing different URL objects now return false

[tr1ckydev]

Summary

Previously, jest would report this test as PASS.

test('url test', () => {
    expect(new URL("https://jestjs.io/")).toEqual(new URL("https://jestjs.io/docs/getting-started"));
});

In this pull request, this gets fixed and jest properly compares the two URL objects and reports FAIL.

Test plan

test('url test', () => {
    expect(new URL("https://jestjs.io/")).toEqual(new URL("https://jestjs.io/"));
});
// Results in PASS.

test('hash test', () => {
    expect(new URL("https://jestjs.io/docs/getting-started")).toEqual(new URL("https://jestjs.io/docs/getting-started#using-babel"));
});
// Results in FAIL.

[linux-foundation-easycla]

• ❌ - login: @tr1ckydev / name: Aritra Karak . The commit (2a917c5) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[netlify]

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	2a917c5
🔍 Latest deploy log	https://app.netlify.com/sites/jestjs/deploys/64d4a18ac96afe00084158d0
😎 Deploy Preview	https://deploy-preview-14398--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mrazauskas]

In Node test environment everything works as you expect. This is only an issue with Jsdom. Better open an issue, because it can be that Jest is not the cause of this problem.

[mrazauskas]

Seems like you are hitting #13936. That issue got missed and locked unfortunately. Just open a new ticket.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

[SimenB]

Even if we look at symbol properties, I think we can have a fast path that just checks the href like this PR proposed.

@tr1ckydev would you be willing to restore your fork?

[tr1ckydev]

@SimenB Sure, should I open a new PR?

[SimenB]

Yeah, unless this one just reopens 🙂

[tr1ckydev]

Done #14672

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.