-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with inline snapshots when snapshot is string not template literal #14465
Fix bug with inline snapshots when snapshot is string not template literal #14465
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet, thanks!
tyvm for the quick turnaround and the notification that it's been released |
All credits to @bawjensen for this, but happy to hear it helped you! 😀 most feedback I get are people complaining, so happy to see some people appreciate the work we all do 👍👍 |
ah @bryan-codaio is me posting from the wrong account 😅 I can relate to appreciating the positive feedback to offset the negative - most folks don't remember to mention the good moments (I almost forgot to follow up here after bumping the dependency version to 29.7.0), so I try to make a point of it |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #14464.
Please let me know what else I can do to flesh this PR out. I could quite well be overlooking something.
Test plan
Added a unit test.