-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Readme.md for @jest/utils #14467
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
packages/jest-util/Readme.md
Outdated
|
||
This packages is a collection of utilities and helper functions | ||
|
||
## [clearLine.ts](https://github.com/jestjs/jest/blob/v29.6.4/packages/jest-util/src/clearLine.ts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## [clearLine.ts](https://github.com/jestjs/jest/blob/v29.6.4/packages/jest-util/src/clearLine.ts) | |
## `clearLine` |
something like that for all of them? we don't need the links I think 🙂
packages/jest-util/Readme.md
Outdated
This packages is a collection of utilities and helper functions | ||
|
||
## [clearLine.ts](https://github.com/jestjs/jest/blob/v29.6.4/packages/jest-util/src/clearLine.ts) | ||
- It ensures that the clearing operation is only performed when running in a terminal environment, and not when the output is redirected to a file or another non-terminal destination. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It ensures that the clearing operation is only performed when running in a terminal environment, and not when the output is redirected to a file or another non-terminal destination. | |
It ensures that the clearing operation is only performed when running in a terminal environment, and not when the output is redirected to a file or another non-terminal destination. |
I don't think we need this as a bullet point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure will commit the suggested changes soon 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, thanks! 👍
packages/jest-util/Readme.md
Outdated
@@ -0,0 +1,66 @@ | |||
# [@jest/utils](https://github.com/jestjs/jest/blob/v29.6.4/packages/jest-util/src/index.ts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the link here as well 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh!, Sorry let me correct it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the entries could be sorted in alphabetical order?
Good idea |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I like this order, it works.
Please take a look at lint errors on CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonderful, thank you so much!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This PR fixes #14457
Please let me know if any changes to make (if any required) in this.
Test plan
None