Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@jest/resolve): replace unmatched capture group with empty string instead of "undefined" (#14500) #14507

Merged
merged 3 commits into from
Sep 11, 2023
Merged

fix(@jest/resolve): replace unmatched capture group with empty string instead of "undefined" (#14500) #14507

merged 3 commits into from
Sep 11, 2023

Conversation

niklasholm
Copy link
Contributor

Summary

Fixes issue #14500

Test plan

Added unit test to verify that the resolver returns the correct result after the change.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 10, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: niklasholm / name: Niklas Holm (bdc6834)
  • ✅ login: SimenB / name: Simen Bekkhus (b682e83, 4d2fe80)

@netlify
Copy link

netlify bot commented Sep 10, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4d2fe80
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/64febff21a85a3000811f862
😎 Deploy Preview https://deploy-preview-14507--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 👍

@SimenB SimenB merged commit 56793ab into jestjs:main Sep 11, 2023
81 of 89 checks passed
@SimenB
Copy link
Member

SimenB commented Sep 12, 2023

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants