Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposes globalConfig to custom test sequencers #14535
Exposes globalConfig to custom test sequencers #14535
Changes from 5 commits
cfc5f07
5372e85
ab2d755
09e7b16
fc2d1e1
636a84f
b4144a6
f22f423
fe73276
5fc7262
8b6c899
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is ideal, but since the Jest
TestSequencer
doesn't use either contexts, or globalConfig, it should be fine to have stand ins here, for now.Alternatively we could make
TestSequencerOptions
optional, or even properly create contexts and globalConfig in the beforeEach.lmk what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this test you can use
jest/packages/test-utils/src/config.ts
Line 131 in 0afd8f1
But it might need to be optional so it's not a breaking change (i.e. a newer version of
@jest/test-scheduler
than the version of@jest/core
). However, I think the next release of Jest will be a major, in which case we don't need it to be optional.