-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jest.spyOn() unit test in JestObjectAPI.md #14625
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! can you update all versions of this docs, and sign the CLA?
@faizanu94 instructions for CLA is in this comment: #14625 (comment) |
…getter definition]
@SimenB it's done, also updated all versions of docs - thanks! |
@SimenB few actions encountered a resource busy or locked error - can we initiate a rerun? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! CI errors look like flake
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Since the exiting unit test mentioned at https://jestjs.io/docs/jest-object#jestspyonobject-methodname-accesstype gets failed dues to
play
being called as function, this PR fixes the test by accessing the play method as property due to its getter definition