fix(jest-worker): failed assertion with circular value hangs the test run

[nodkz]

Relates #10577

Summary

When an assertion fails where either the expected or actual value is circular, and both values are objects, jest encounters an error stating it failed to convert a circular structure to JSON, resulting in the test run not completing.

This PR fixes sending result with circular references from worker to runner.

       TypeError: Converting circular structure to JSON
        --> starting at object with constructor 'ClientRequest'
        |     property 'socket' -> object with constructor 'TLSSocket'
        --- property '_httpMessage' closes the circle
        at stringify (<anonymous>)

      at messageParent (node_modules/jest-worker/build/workers/messageParent.js:29:19)

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: nodkz / name: Paul Damnhorns (b06be16, d2ebca4, 9dd6e67, 14ddff0, b8c6ba0, 8bc7473, 8ece12d, d76b9a2)

[netlify]

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	d76b9a2
🔍 Latest deploy log	https://app.netlify.com/sites/jestjs/deploys/65490d6a5a7a3300086813d0
😎 Deploy Preview	https://deploy-preview-14675--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nodkz]

✅ PR is ready for review @SimenB @fa93hws

[nodkz]

Close/open for test re-run

[nodkz]

rerun tests again due to infra reliability (yarn install on mac)

[nodkz]

rerun again

[SimenB]

thanks, awesome to see some movement on this!

Can you also unskip this?

jest/e2e/__tests__/circularInequality.test.ts

Line 28 in 4fedfbd

test.skip('handles circular inequality properly', async () => {

[SimenB]

can we do the inverse as well - rebuild the object with the circular references in place?

I.e. what https://www.npmjs.com/package/flatted does (I see they now wanna push users to https://github.com/ungap/structured-clone/blob/main/README.md#extra-features, might be worth a look)

[nodkz]

@SimenB flatted and structured-clone have own serialization format, so both jest-runner and jest-worker should have the same serialize/parse logic. But currently runner and worker are different packages and end-users might have different versions on their installation.

So we break a transport layer by this improvement. Better to do it in another PR as improvement and R&D, this PR is a bug fix PR. And I'm very sorry but I don't have enough bandwidth to deal with bumping v30 😉

[nodkz]

@SimenB friendly ping ;)

[github-actions]

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[github-actions]

This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.

[github-actions]

This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.