Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce %$ option to add number of the test to its title #14710

Conversation

kemuridama
Copy link
Contributor

Summary

%# option to add index of the test to its title has been introduced by #6414. Similarly to it, I want to add number of the test to its title.

This PR proposes to add %$ option to add number of the test to its title.

I don't know that %$ is suitable as a placeholder. So I'd appreciate it if you could consider that point.

Test plan

Tests have been added.

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b4e3267
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6600da4a10a5530008384fd3
😎 Deploy Preview https://deploy-preview-14710--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

linux-foundation-easycla bot commented Nov 22, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@SimenB
Copy link
Member

SimenB commented Dec 25, 2023

@mattphillips thoughts? I like the feature, but I'm also unsure about using $

Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Mar 24, 2024
@github-actions github-actions bot removed the Stale label Mar 25, 2024
@SimenB SimenB added the Pinned label Mar 26, 2024
@SimenB SimenB added this to the Jest 30 milestone Mar 26, 2024
@SimenB
Copy link
Member

SimenB commented Mar 26, 2024

@mattphillips would love your input here 😀 I'm inclined to land it 🙂

@mattphillips
Copy link
Contributor

Hey @kemuridama thanks for the PR, the code looks good to me to be merged. I'm not 100% on $ and if it has any existing mappings in printf but a very quick google search I didn't see any obvious issues

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Thanks!

@SimenB SimenB merged commit b7541ac into jestjs:main May 29, 2024
73 checks passed
@SimenB
Copy link
Member

SimenB commented May 30, 2024

https://github.com/jestjs/jest/releases/tag/v30.0.0-alpha.5

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants