Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-config): allow reporters in project config #14768

Merged
merged 9 commits into from
Dec 25, 2023

Conversation

jeremiah-snee-openx
Copy link
Contributor

Summary

jest currently warns that reporters as a unknown option, when configured at the project level config. But the project level configuration still applies the value.

image

Reporters is useful in project config for custom outputDirectory. Personally used with NX monorepo

#13576

Test plan

existing tests pass

Note: this is in reference #13576
Where options are validated as invalid for the project level potentially incorrectly. reporters Option throws warning about, but still works on the project level and appear to be used in most cases.

yarn build
yarn test

Copy link

linux-foundation-easycla bot commented Dec 20, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7e68dcb
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/658965277ecaf100085c656b
😎 Deploy Preview https://deploy-preview-14768--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jeremiah-snee-openx jeremiah-snee-openx marked this pull request as draft December 20, 2023 22:39
@jeremiah-snee-openx jeremiah-snee-openx marked this pull request as ready for review December 20, 2023 22:39
@jeremiah-snee-openx
Copy link
Contributor Author

jeremiah-snee-openx commented Dec 20, 2023

For Awareness from #13576

@mhornbacher @SimenB @tscislo @andrew-productiv @dmeents

@arivera-xealth @woppa684

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 04204e4 into jestjs:main Dec 25, 2023
8 of 9 checks passed
@jeremiah-snee-openx jeremiah-snee-openx deleted the Fix-Reporters-Validation branch December 26, 2023 17:07
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2024
@SimenB
Copy link
Member

SimenB commented Feb 20, 2024

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants