-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow templating of null and undefined in a jest each key path template #14831
fix: allow templating of null and undefined in a jest each key path template #14831
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
5eb4ab8
to
6af8f19
Compare
hmm, not sure why the tests are now failing 😢 |
6af8f19
to
c67c4bf
Compare
The one failing test is a known one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! just a minor change needed to actually run the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
See newly added e2e tests, currently jest crashed with:
when adding a nested keypath as a template in a null or undefined object. Instead we just early-exit out of interplation in those cases.
Test plan
yarn test
yarn constraints