Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to customize the serializable properties during error report #14893

Merged
merged 3 commits into from
Mar 17, 2024

Conversation

georgekaran
Copy link
Contributor

Closes #14892

Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7602f39
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/65f61057845248000839a1b3
😎 Deploy Preview https://deploy-preview-14893--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

linux-foundation-easycla bot commented Feb 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, thanks!

Could you add some documentation for this feature? Probably somewhere in https://jestjs.io/docs/expect

Also, please add a changelog entry 🙂

@georgekaran
Copy link
Contributor Author

I like the idea, thanks!

Could you add some documentation for this feature? Probably somewhere in https://jestjs.io/docs/expect

Also, please add a changelog entry 🙂

Thanks for the review!

Let me know what you think about the docs; I've tried to be as straightforward as possible about its use case.

@georgekaran georgekaran requested a review from SimenB March 16, 2024 21:43
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful, thank you!

@SimenB SimenB merged commit ba355a4 into jestjs:main Mar 17, 2024
73 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow to customize the serializable properties during error report
2 participants