feat: Add DEC mode 2026 support (Synchronized Output) to Jest #15008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces support for DEC private mode 2026, also known as Synchronized Output, to DefaultReporter. The Synchronized Output mode is a terminal feature that helps mitigate screen tearing effects that can occur when the terminal is rendering output while the application is still writing to the screen. Two new methods have been added to the DefaultReporter: - `__beginSynchronizedUpdate`: This method sends the control sequence to enable Synchronized Output mode to the terminal. - `__endSynchronizedUpdate`: This method sends the control sequence to disable Synchronized Output mode to the terminal. These methods are called before and after the reporter updates the status, respectively. By doing this, we ensure that the terminal renders a consistent state of the screen for each status update, even if we're writing to the screen frequently. Read more: https://gist.github.com/christianparpart/d8a62cc1ab659194337d73e399004036
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SimenB
approved these changes
Apr 5, 2024
| @@ -120,6 +124,26 @@ export default class DefaultReporter extends BaseReporter { | |||
| } | |||
| } | |||
|
|
|||
| protected __beginSynchronizedUpdate(): void { | |||
There was a problem hiding this comment.
Is it intentional that we check _globalConfig every time we have a write operation?
I'm waiting on hearing from the legal team at Netflix on how to proceed here. I don't anticipate this taking too long though! Thanks for your patience. |
haze
force-pushed
the
pr/hb/jest/mode-2026
branch
from
c8de1b1
to
4cd1df9
Compare
|
@SimenB CLA Signed! |
4 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces support for DEC private mode 2026, also known as Synchronized Output, to DefaultReporter. The Synchronized Output mode is a terminal feature that helps mitigate screen tearing effects that can occur when the terminal is rendering output while the application is still writing to the screen.
Two new methods have been added to the DefaultReporter:
__beginSynchronizedUpdate: This method sends the control sequence to enable Synchronized Output mode to the terminal.__endSynchronizedUpdate: This method sends the control sequence to disable Synchronized Output mode to the terminal.These methods are called before and after the reporter updates the status, respectively. By doing this, we ensure that the terminal renders a consistent state of the screen for each status update, even if we're writing to the screen frequently.
Read more: https://gist.github.com/christianparpart/d8a62cc1ab659194337d73e399004036
Why / Test plan
Here's Jest output before (notice the flickering):
jest.output.bad.mp4
Here's Jest output after:
jest.output.good.mp4