-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move unnecessary dependencies
to devDependencies
for babel plugins
#15010
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
dependencies
to devDependencies
for babel-plugin-jest-hoist
dependencies
to devDependencies
for babel plugin
dependencies
to devDependencies
for babel plugindependencies
to devDependencies
for babel plugins
I thought these endes up in our public types, but maybe that has changed? |
You're right! I should look for another solution, especially with babel/babel#16416. |
Yeah https://www.runpkg.com/?babel-plugin-jest-hoist@29.6.3/build/index.d.ts Seems we can remove |
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
@liuxingbaoyu what are the plans for this one? 🙂 |
5ad03a6
to
6cd4b70
Compare
Sorry I forgot about it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
I found it at babel/babel#16413 and although I've added the solution in Babel, it looks like removing them in Jest is fine.
Test plan
CI green