refactor!: make it mandatory to pass globalConfig to the Runtime constructor
#15044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
mrazauskas
commented
Apr 30, 2024
Comment on lines
2373
to
+2374
| // TODO: remove this check in Jest 30 | ||
| if (this._globalConfig?.seed === undefined) { | ||
| if (this._globalConfig.seed === undefined) { |
There was a problem hiding this comment.
Initially I wanted to remove these checks since they are not needed in Jest 30. But here it also makes sure that this._globalConfig is defined.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes it mandatory to pass
globalConfigto theRuntimeconstructor.Test plan
Green CI.