Fix error message for sl (steam locomotive)
#15052
Conversation
When running jest in watch mode, with `sl` installed (https://github.com/mtoyoda/sl), it errors out with the following message: ``` ● Test suite failed to run thrown: [Error] ``` This is bad because the error is extremely hard to debug. This change makes it error as follows: ``` ● Test suite failed to run Command failed with ENAMETOOLONG: sl status -amnu /Users/rmartine/dev/ias-backstage/packages/backend spawn ENAMETOOLONG ``` This, at least, points people in the right direction. See also: jestjs#14046
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
minor: just make the error message say "This is probably because you have Steam Locomotive installed. Jest cannot be used with Steam Locomotive installed." |
|
Well, now it can. See my other PR: #15053 |
|
|
||
| throw error; | ||
| } | ||
| const result = await execa('sl', args, {cwd, env}); |
There was a problem hiding this comment.
can we make the same change for all the VCS checks? trying to silence the error doesn't really seem useful in this case
There was a problem hiding this comment.
Made the change, added changelog entry!
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
When running jest in watch mode, with
slinstalled(https://github.com/mtoyoda/sl), it errors out with the following
message:
This is bad because the error is extremely hard to debug.
This change makes it error as follows:
This, at least, points people in the right direction.
See also: #14046
Test plan
Went to a project that uses jest, ensured
slwas installed and on$PATH, and ran:$ node /path/to/your/JestClone/packages/jest/bin/jest --watchConfirmed error was as before:
Made my changes, re-ran:
$ node /path/to/your/JestClone/packages/jest/bin/jest --watchConfirmed error message is now descriptive: