chore!: drop support for Node.js 21 #15118
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -24,7 +24,8 @@ describe('Wrong globals for environment', () => { | |||
| assertFailuresAndSnapshot(['node', '-t=document']); | |||
| }); | |||
|
|
|||
| onNodeVersions('<21', () => { | |||
| // Node.js 18 is the last LTS version, which is missing the global 'navigator' | |||
| onNodeVersions('<=18', () => { | |||
There was a problem hiding this comment.
This test will be obsolete after dropping Node.js 18. So I though, perhaps keeping 18 here makes it easier to notice that?
|
@SimenB Could you take a look, please? GHA is waiting for status checks on Node v21.x, because these are marked as required. Not so easy to remove them (; |
|
Not sure about this. It would mean people supporting So yeah, I think I convinved myself 😀 |
|
I think that is fine, since Node.js does not recommend the odd versions for production anyways. Play with it, have fun, but that is it. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Perhaps it is time to drop Node.js 21? It is end-of-life since 2024-06-01. Reference: https://github.com/nodejs/Release
Test plan
Green CI.