-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GettingStarted.md with current Vite related information #15122
Conversation
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks. I was looking at the text again. Perhaps it would be enough to say that Vite's plugins are not compatible with Jest's transforms? And to point to the issue in Vite's repo? Users can find all details and possible solutions there. Also it does not look right to advertise another testing framework. That's for sure is a red flag (; |
@mrazauskas as a new Vite + Vitest user, I find that it helps having some context about other tools that have been used in the past and are no longer recommended or don't work anymore, since you can still find posts recommending vite-jest on StackOverflow or other places |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they've copy pasted so much code it's weird, but I do agree with linking to them as the alternative is deprecated 😀
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
As per #15121 the current information regarding usage with Vite is out of date. The recommended compatibility library vite-jest appears to be unmaintained and is not compatible with the current Vite release.
Additionally, this change points users to Vitest, a currently maintained alternative to which I have found migration relatively painless.
Test plan
No tests, just documentation.