Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support anonymous custom element constructors #15138

Merged
merged 8 commits into from
Jun 30, 2024
Merged

Conversation

KonnorRogers
Copy link
Contributor

@KonnorRogers KonnorRogers commented Jun 19, 2024

Summary

Support anonymous custom elements

Fixes #15137

Test plan

Copy link

linux-foundation-easycla bot commented Jun 19, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dfd09d6
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/667b17a3d7a5e20008fddfd5
😎 Deploy Preview https://deploy-preview-15138--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB
Copy link
Member

SimenB commented Jun 24, 2024

Thanks! Can you add a test and a changelog entry?

@KonnorRogers
Copy link
Contributor Author

@SimenB Done!

CHANGELOG.md Outdated
@@ -40,6 +40,7 @@

### Fixes

- `[pretty-format]` Fixed a bug where "anonymous custom elements" were not being printed as expected. ([#15138](https://github.com/jestjs/jest/pull/15138))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put it in alphabetical order? (On mobile, or I'd do it myself)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 my bad. Will do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB Done

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 3176a4e into jestjs:main Jun 30, 2024
84 checks passed
Copy link

github-actions bot commented Aug 2, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2024
@SimenB
Copy link
Member

SimenB commented Aug 8, 2024

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Jest fails to serialize custom elements with anonymous constructors
2 participants