Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove expressjs reference material as domain has expired #15270

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

brandonnorsworthy
Copy link
Contributor

@brandonnorsworthy brandonnorsworthy commented Aug 22, 2024

👉😎👉

might make a guide after I get it working and learn more for my TS Express app I am adding jest to. Just something I discovered

existing page: https://jestjs.io/docs/testing-frameworks#expressjs

✅ changelog

Summary

After attempting to look at the material for Express.JS someone had linked to their personal guide you are greeted by a parked domain / domain expirey leading you no where.

Current link: http://www.albertgao.xyz/2017/05/24/how-to-test-expressjs-with-jest-and-supertest/

Test plan

yarn install
cd website
node fetchSupporters.js
yarn start
Screenshot 2024-08-22 at 6 34 40 PM

Copy link

linux-foundation-easycla bot commented Aug 22, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7a21d6a
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/66c7cd8b50358f0008085bb6
😎 Deploy Preview https://deploy-preview-15270--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonnorsworthy brandonnorsworthy marked this pull request as ready for review August 22, 2024 23:45
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit bd1c6db into jestjs:main Aug 23, 2024
73 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants