- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6.6k
chore!: drop support for end-of-life Node 18 #15850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            hainenber
  wants to merge
  4
  commits into
  jestjs:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
hainenber:feat/drop-eol-node-v18-support
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            
          
      
        
          +62
        
        
          −92
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Signed-off-by: hainenber <dotronghai96@gmail.com>
| ✅ Deploy Preview for jestjs ready!Built without sensitive environment variables 
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
| babel-jest
 babel-plugin-jest-hoist
 babel-preset-jest
 create-jest
 @jest/diff-sequences
 expect
 @jest/expect-utils
 jest
 jest-changed-files
 jest-circus
 jest-cli
 jest-config
 @jest/console
 @jest/core
 @jest/create-cache-key-function
 jest-diff
 jest-docblock
 jest-each
 @jest/environment
 jest-environment-jsdom
 @jest/environment-jsdom-abstract
 jest-environment-node
 @jest/expect
 @jest/fake-timers
 @jest/get-type
 @jest/globals
 jest-haste-map
 jest-jasmine2
 jest-leak-detector
 jest-matcher-utils
 jest-message-util
 jest-mock
 @jest/pattern
 jest-phabricator
 jest-regex-util
 @jest/reporters
 jest-resolve
 jest-resolve-dependencies
 jest-runner
 jest-runtime
 @jest/schemas
 jest-snapshot
 @jest/snapshot-utils
 @jest/source-map
 @jest/test-result
 @jest/test-sequencer
 @jest/transform
 @jest/types
 jest-util
 jest-validate
 jest-watcher
 jest-worker
 pretty-format
 commit:  | 
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Summary
Node v18 has been declared to be End-of-Life on March 27th, 5 months ago. We should drop its support to unlock further enhancements to Jest like updating dependencies to ESM-only major version.
Test plan
Green CI