-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore: upgrade TypeScript and @types/node
#15861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
babel-jest
babel-plugin-jest-hoist
babel-preset-jest
create-jest
@jest/diff-sequences
expect
@jest/expect-utils
jest
jest-changed-files
jest-circus
jest-cli
jest-config
@jest/console
@jest/core
@jest/create-cache-key-function
jest-diff
jest-docblock
jest-each
@jest/environment
jest-environment-jsdom
@jest/environment-jsdom-abstract
jest-environment-node
@jest/expect
@jest/fake-timers
@jest/get-type
@jest/globals
jest-haste-map
jest-jasmine2
jest-leak-detector
jest-matcher-utils
jest-message-util
jest-mock
@jest/pattern
jest-phabricator
jest-regex-util
@jest/reporters
jest-resolve
jest-resolve-dependencies
jest-runner
jest-runtime
@jest/schemas
jest-snapshot
@jest/snapshot-utils
@jest/source-map
@jest/test-result
@jest/test-sequencer
@jest/transform
@jest/types
jest-util
jest-validate
jest-watcher
jest-worker
pretty-format
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades TypeScript and @types/node dependencies to address compatibility issues with newer Node.js APIs. The upgrade resolves type errors related to experimental VM modules that are now officially supported.
- Removes TypeScript version restriction and updates @types/node to 18.x
- Fixes type assertions and removes experimental type suppressions for VM modules
- Updates function signatures to use proper TypeScript types instead of type suppressions
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates @types/node version constraint and removes TypeScript version pinning |
| eslint.config.mjs | Adds defineConfig import and updates configuration function call |
| packages/jest-resolve/src/shouldLoadAsEsm.ts | Removes ts-expect-error comment for SyntheticModule import |
| packages/jest-runtime/src/index.ts | Major type system improvements, removes experimental type suppressions |
| packages/jest-test-sequencer/src/tests/test_sequencer.test.ts | Adds async keywords to map callback functions |
| packages/jest-worker/src/workers/tests/NodeThreadsWorker.test.ts | Adds type cast for Stream interface |
| packages/jest-worker/src/workers/tests/ChildProcessWorker.test.ts | Adds type cast for Stream interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
There are some casts added, but previously it was all implicitly Will need to revisit all of this stuff for |
Summary
Being on an old version is suboptimal, let's see if we can upgrade 🙂
Test plan
CI