Make typeahead play better with different terminals #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
super solid work. Thanks @rogeliog. I'm really impressed. |
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
* Make typeahead more cross terminal. * Clear typeahead on exit and fix flow error * Update watch-pattern-mode-test.js
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Make typeahead more cross terminal. * Clear typeahead on exit and fix flow error * Update watch-pattern-mode-test.js
This was referenced Oct 4, 2018
First character(s) not rendering correctly in some terminals.
jest-community/jest-watch-typeahead#20
Closed
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a some issues when using typeahead in different terminals mainly (xterm vs screen)
Issues that this PR fixes
1) The cursor is in weird positions when using Terminal.app
See sindresorhus/ansi-escapes#1 for more info about why this happens
To fix this instead of clearing the whole screen every time we are only clearing it then the user goes into pattern mode.
ansiEscapes.cursorRestorePositionwe useansiEscapes.cursorToas a fallbackansiEscapes.cursorRestorePositionwe use that.NOTE: This also fixes an issue where the cursor in iTerm2 jumps around
2) Killing the process while the typeahead is active leaves some ghost characters.
Before
After
I've been testing typeahead mode in the following environments and it seems fine.
Here is a mega gif how it works in each and every env
NOTE: I had some weird issues with my terminal half way through the video, feel free to either ignore it or troll me.
Final Notes