Add note to Webpack docs about how to handle dynamic imports #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Feb 3, 2017
| @@ -212,7 +212,7 @@ thus requires ES modules to be transpiled to CommonJS modules. As such, if you | |||
| are using webpack 2, you most likely will want to configure Babel to transpile | |||
| ES modules to CommonJS modules only in the `test` environment. | |||
|
|
|||
| ```js | |||
| ```json | |||
There was a problem hiding this comment.
Unless you assign it to a variable it's not valid JS...
|
thanks! I guess this is still fairly new and people don't know so much about it yet. |
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
…2800) * Add note to Webpack docs about how to handle dynamic imports * Update Webpack.md
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
…2800) * Add note to Webpack docs about how to handle dynamic imports * Update Webpack.md
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I went the long way around to find this... Having it easily available in the docs would be nice.
Ref #2442
Test plan
N/A