Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Human-readable colors for jest-matchers snapshots #3119

Merged
merged 3 commits into from
Mar 10, 2017
Merged

Human-readable colors for jest-matchers snapshots #3119

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11d7ae2
Human-readable colors for jest-matchers snapshots
thymikee Mar 10, 2017
d011d5b
Use ConvertAnsi pretty-format plugin as snapshotSerializer
thymikee Mar 10, 2017
2112c92
Convert ansi escapes in all snapshots
thymikee Mar 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/jest-matchers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,10 @@
"jest-matcher-utils": "^19.0.0",
"jest-message-util": "^19.0.0",
"jest-regex-util": "^19.0.0"
},
"devDependencies": {
"ansi-regex": "^2.1.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are ansi-regex and ansi-styles added?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I use them in here: https://github.com/facebook/jest/pull/3119/files#diff-5d7e608b44e8080e7491366117a2025fR20
They're also already available through chalk

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make ansi-styles and ansi-regex devDependencies of the top level package.json instead? jest-snapshot should stay here but please use the latest version (19.0.2).

"ansi-styles": "^3.0.0",
"jest-snapshot": "^19.0.0"
}
}
Loading