Resolve issues relating to website builds: removed 4-spaces from generated file templates, adds crowdin-cli dependency for two way syncing of docs #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding additional settings to prettier.js to catch unformatted files in packages/* Running 'yarn prettier'
Codecov Report
@@ Coverage Diff @@
## master #3369 +/- ##
=======================================
Coverage 64.89% 64.89%
=======================================
Files 176 176
Lines 6521 6521
Branches 4 4
=======================================
Hits 4232 4232
Misses 2288 2288
Partials 1 1
Continue to review full report at Codecov.
|
|
Awesome! |
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
Adding additional settings to prettier.js to catch unformatted files in packages/* Running 'yarn prettier'
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolve issues relating to file templates that generate files with 4-spaces. I also added a required CLI "crowdin-cli" to allow for two way syncing of docs during CI build step.